Fix string negative indexing#323
Merged
Merged
Conversation
Contributor
|
Thanks for the contribution. One thing I'm wondering here is whether string indexing should match List (where a negative index means count from the end... or throw an error). It might be worth looking at what other languages do. |
Contributor
|
We decided that, for now, it's better to alert the user of potential out-of-bounds access. List, Matrix and Tuple all permit negative indices, but the use-case for String is less clear. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for bug #321. Strings now throw an error if the user attempts to index them negatively. Added a test to the suite to check for this behavior.
Internally, this bug appeared because the string index operation was calling the enumerate function instead of a dedicated get index function.